Some arguments when evaluating whether or not to merge to master:ġ- Despite the large number of changed lines, they are mostly localized in 2 files wifi.cpp, wifi.h which aren't useful in their current state (before merge) anyway.Ģ- Changes to other files are minor such as adding command line options, include statements and logging function. So to answer your question, I am not planning to develop WiFi functionality any further than current state (Only infrastructure mode working correctly), but I can work my way around bugs that might be introduced by future commits and maintain it for the foreseeable future. Apart from that, the rest of the changes are fairly easy to read through and maintain.
#DESMUME WIFI CODE#
Which leaves us here.Īs explained above, I have no relation with the development of the changes related to fixing WiFi and I am not familiar with the inner workings of WiFi on the NDS and thus the logic behind the code in wifi.cpp and wifi.h. I forked desmume and applied the commits to a separate branch, fixed some missing includes and tested that build for a while. Jackobo didn't create an online fork of demume due to some conflicts with desmume developers, so I got the date Jackobo locally cloned the master branch from his post in this forum, cloned the desmume master branch at that date, and generated diff between his fork and that to get his commits. To prevent that work from being out of date after some time (especially that it is functioning very well), this should be merged upstream. Thankfully though, someone else forked it before that. I found Jackobo's post here but his repository was gone. I am new to GitHub, and this is my first time trying to contribute to an open source project.Īs to why I am doing this, I wanted an up to date build with working WiFi to use myself. Instructions for setting up WiFi and connecting to AltWFC network Closing the pull request didn't remove the build, sorry about that.Īfter testing for some time, I merged the changes in master20180622_test_WiFi to master branch, and rebased on current TASVideos/desmume master branch (bd63ff1 Tree).
I originally submitted a pull request for the changes, but closed it after I saw the official auto builder immediately applied it.
#DESMUME WIFI WINDOWS#
Please review the branch with working WiFi here:Īnd the compiled (圆4) windows executable at:Īll credit for the 0.9.12 WiFi fix goes to Jackobo Le Chocobo, and for original code to Luigi_/StapleButter I applied the relevant fixes to snapshot of master branch taken at. Picture 3 - Config - 3D Settings : make sure to select OpenGL 3.I created a separate branch in a proper fork of desmume to test WiFi fixes from Desmume-Reloaded by Jackobo Le Chocobo. Picture 2 - Config - Emulation settings : use these settings for fast and safe emulation (disable advanced bus-level timing for more speed) Picture 1 - Config - Frame Skip : This settings will help you prevent slow fps by skipping rendering frames (ticking Auto-Minimize Skipping will help skipping frames only when there is lag so when there isn't lag the emu will not skip any frames resulting in smooth gameplay) so increase the frame skipping basing on Your hardware capabilities I Love DeSmuME ! So i want to share my own optimal settings for you !
0 kommentar(er)
